Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure support for multiple Node.js versions. #1440

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensure support for multiple Node.js versions. #1440

wants to merge 2 commits into from

Conversation

rishabh1S
Copy link
Contributor

@rishabh1S rishabh1S commented Sep 27, 2023 •
edited
Loading

Description

This pull request addresses Issue #1118
Ensure support for multiple Node.js versions.

Changes

  • Updated the GitHub Actions workflow to support multiple Node.js versions.
  • Added a strategy matrix for testing on Node.js versions 14.x, 16.x, and 18.x.

Closes #1118

@ghost
Copy link

ghost commented Sep 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@rishabh1S rishabh1S changed the title Closes #1118 Ensure support for multiple Node.js versions. Sep 27, 2023
@javiertoledo
Copy link
Member

Thanks for the PR, but it seems that the project is not currently working on Node 18, so we'll need to keep this on hold a little bit until it's fixed. We're working on the node18 upgrade in #1431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD: Ensure all Node.js versions are supported
2 participants
@rishabh1S @javiertoledo